Disambiguate remote end steps dfn link
#84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like CI possibly needs to be updated? It's failing to install bikeshed: |
|
@jyasskin can you help with the CI problem? Or point us to someone who can? |
|
Probably triggered by actions/runner-images#10636. I've filed w3c/spec-prod#189, and I'll send a PR, but I won't have time to test it. |
|
You can work around the problem by changing toubuntu-22.04.
|
|
@svendlarsen can you rebase this on the tool chain change to see if it passes CI now? |
b95525a to
de1ad76
Compare
|
Yep, success! |
github-actions bot
added a commit
that referenced
this pull request
Oct 15, 2024
SHA: 00cf8bb Reason: push, by wanderview Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
amaliev
pushed a commit
to amaliev/nav-tracking-mitigations
that referenced
this pull request
Oct 18, 2024
amaliev
pushed a commit
to amaliev/nav-tracking-mitigations
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
bikeshedon main yields the following output:i.e., bikeshed selects the wrong dfn link for
remote end steps.With this change, running
bikeshedproduces no warnings and correctly links to the webdriver spec's dfn forremote end steps.Preview | Diff