fix: call getter accumulator with proper this context
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks 👍 |
thetutlage
added a commit
that referenced
this pull request
Oct 14, 2023
* feat: rewrite from scratch * docs: update links to badges * ci: run tests for lts and latest version of Node * test: fix breaking test * chore(release): 1.0.0-0 * chore: update dependencies * chore: make tsconfig strict * chore: track coverage * docs: improvements to examples * chore(release): 1.0.0-1 * chore: update dependencies * ci: use reusable workflow * chore: update dependencies * refactor: export Macroable as default Breaking change: Single values should always be exported as default export * chore(release): 1.0.0-2 * chore: update dependencies * docs(README): fix badge url for github workflow * chore: update dependencies * chore(release): 1.0.0-3 * chore: update dependencies * docs(README): update codeblocks * chore(release): 1.0.0-4 * fix: call getter accumulator with proper `this` context (#31) * fix: call getter accumulator with proper this context * style: remove unused import * chore: update dependencies * chore(release): 1.0.0-5 * chore: update dependencies * feat: allow re-assigning getters * chore(release): 1.0.0-6 * chore: update dependencies * chore: upgrade japa to v3 * chore: use @adonisjs/tooling presets for tooling config * ci: add linting and typechecking in ci * test: add expect-type plugin * chore: add engines to package.json file * chore(release): 1.0.0-7 * chore: update dependencies * docs: update README * chore(release): 1.0.0-8 * chore: update dependencies * chore: publish under latest tag * chore: use tsup for bundling --------- Co-authored-by: Julien Ripouteau <julien@ripouteau.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Without this fix, then the following code did not work:
In other words: the
thiscontext was not passed to the getters callback. I added a test in the PR that showed this behavior.This also caused an undesired breaking change