fix: scroll to top twice on receiving a note #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to call `scrollToTop` twice when receiving a note from a stream. The first call will be done 100 ms after the event, and the second call will be 100 ms after the first scroll is done. This change makes timelines scroll to their exact top edge even though the size of notes changes over time while rendering emojis or images.
fb8956f to
89e5815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to call
scrollToToptwice when receiving a note from a stream.The first call will be done 100 ms after the event, and the second call will be 100 ms after the first scroll is done.
This change makes timelines scroll to their exact top edge even though the size of notes changes over time while rendering emojis or images.