feat: scroll to last viewed date if older notes have been fetched #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed scroll behavior of when the "last viewed at" banner is tapped.
Scrollable.ensureVisible()also scrolls in a horizontal direction and makes unintended movements.TimelineNotesNotifieris older than the last viewed date, repeatedly scroll for small offsets to find the divider.centerIdand jump to the date.We want to avoid the third case because fetching notes created after a date sometimes requires multiple requests.
So increased the number of notes fetched on build to make it more likely to be caught in the second case.