prevent DefaultValue from being set when the localStorage state does not contain the key. Fixes #26 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…does not contain the key. Fixes polemius#26
…does not contain the key. Fixes polemius#26
…rtele/recoil-persist into fix/defaultvalue-getting-set
polemius
reviewed
Apr 18, 2021
| newValue instanceof DefaultValue | ||
| ) { | ||
| delete state[node.key] | ||
| if (state.hasOwnProperty(node.key)) delete state[node.key] |
Owner
There was a problem hiding this comment.
Looks like these two construction are the same:
if (a && b) {
}
and
if (a) {
if (b) {
}
}
Author
There was a problem hiding this comment.
They are not the same. If the state does not contain the node.key it will still persist the DefaultValue object because then it will fall in the else branch.
050c87f to
2f70d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #26