这是indexloc提供的服务，不要输入任何密码
Skip to content

Add testing for async use case #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Add testing for async use case #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d8df20
Rename storage interface, clashes with DOM type
rhys-saldanha Feb 6, 2021
3a80833
Move tests into test suite, test both sync and async use cases
rhys-saldanha Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import { AtomEffect } from 'recoil'

interface Storage {
setItem(key: string, value: string): void | Promise<any>
getItem(key: string): null | string | Promise<any>
export interface PersistStorage {
setItem(key: string, value: string): void | Promise<void>

getItem(key: string): null | string | Promise<string>
}

export interface PersistConfiguration {
key?: string
storage?: Storage
storage?: PersistStorage
}

/**
Expand All @@ -24,7 +25,8 @@ export const recoilPersist = (

if (typeof window === 'undefined') {
return {
persistAtom: () => {},
persistAtom: () => {
},
}
}

Expand Down Expand Up @@ -76,6 +78,8 @@ export const recoilPersist = (

const setState = (state: any): void => {
try {
//TODO for React Native `AsyncStorage`, we should be using `mergeItem`
// to merge existing stringified object with new one
storage.setItem(key, JSON.stringify(state))
} catch (e) {
console.error(e)
Expand Down
Loading