Fix for streaming uploads #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds support for streaming async-iterable request bodies and a test to validate error propagation when a generator raises.
- Introduce logic in
_request_mockto consume async iterables indataand replace them with aggregated bytes. - Add
test_async_generator_body_exceptionto ensure a generator exception bubbles up.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_async_generator_body.py | New async test asserting generator errors are propagated |
| aioresponses/core.py | Handle async-iterable data by iterating chunks into bytes |
Comments suppressed due to low confidence (1)
tests/test_async_generator_body.py:12
- [nitpick] Consider adding a complementary test case for successful streaming (no errors) to verify that chunks from an async generator are properly aggregated and sent as the request body.
async def data_generator():
| try: | ||
| body_bytes = b"" | ||
| async for chunk in data: | ||
| body_bytes += chunk |
There was a problem hiding this comment.
Accumulating bytes by repeated concatenation can lead to quadratic memory usage for large streams; consider appending chunks to a list and doing b''.join(chunks) after iteration.
Comment on lines
+507
to
+513
| try: | ||
| body_bytes = b"" | ||
| async for chunk in data: | ||
| body_bytes += chunk | ||
| kwargs['data'] = body_bytes | ||
| except Exception: | ||
| raise |
There was a problem hiding this comment.
The try/except that immediately re-raises the caught exception is redundant; you can remove the try/except block and let exceptions propagate naturally to simplify the code.
Suggested change
| try: | |
| body_bytes = b"" | |
| async for chunk in data: | |
| body_bytes += chunk | |
| kwargs['data'] = body_bytes | |
| except Exception: | |
| raise | |
| body_bytes = b"" | |
| async for chunk in data: | |
| body_bytes += chunk | |
| kwargs['data'] = body_bytes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #270