Fix #4830: Correct slime block physics for items and sneaking players #6900
+19
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
requested changes
Nov 16, 2025
| public function onEntityLand(Entity $entity) : ?float{ | ||
| if($entity instanceof Living && $entity->isSneaking()){ | ||
| $entity->resetFallDistance(); | ||
| if($entity instanceof Living && $entity->isSneaking()){ |
Member
There was a problem hiding this comment.
This indentation is not correct
| if($fallBlock->getTypeId() !== BlockTypeIds::AIR){ | ||
| $this->broadcastSound(new EntityLandSound($this, $fallBlock)); | ||
| } | ||
| return $newVerticalVelocity; |
|
|
||
| if($fallBlock->getTypeId() !== BlockTypeIds::AIR){ | ||
| $this->broadcastSound(new EntityLandSound($this, $fallBlock)); | ||
| } |
Member
There was a problem hiding this comment.
This is going to make dropped items, XP orbs, arrows etc have step sounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4830. This PR moves part of
onHitGroundlogic (which only applied toLiving) toEntitysoItemEntitycan use it.The
Living::onHitGroundmethod was updated to call the parent method first, ensuring fall damage is only calculated after a block (likeSlime) has a chance to reset the fall distance.I also fixed a logic bug in
Slimewhere sneaking players would not bounce (correct) but would still take fall damage (incorrect).I have tested the following in-game scenarios:
ItemEntity(dropped items) now correctly bounce on slime blocks.fallDistanceresets and re-accumulates properly after the bounce).