Add Promise::all
#6152
Merged
Add Promise::all
#6152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOF3
reviewed
Nov 12, 2023
SOF3
reviewed
Nov 12, 2023
dktapps
reviewed
Feb 5, 2024
dktapps
reviewed
Feb 5, 2024
looks like the behaviour of this was quietly broken during a recent change
Member
|
After adding some unit tests I think this is OK to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This method is necessary in certain RPs, and this one tends to take out this modification, which is no longer specific to a single one.
Its aim is to make a Promise that will be resolved when all given Promises have been resolved. It is, however, rejected as soon as the first promise is rejected.
PR needing
Changes
API changes
alltoPromiseTests
See needing PR