Remove StaticAssetsMetadata
#13094
Draft
Remove StaticAssetsMetadata
#13094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurz
commented
Jan 28, 2025
| val path = base + "/" + value.name | ||
| StaticAssetsMetadata.finder.findAssetPath(base, path) | ||
| } | ||
| } |
There was a problem hiding this comment.
This removal could cause problems I guess...
There was a problem hiding this comment.
You are absolutely right. This is binder for Assets for generated routes are like
GET /public/*file controllers.Assets.versioned(path = "/public", file: controllers.Assets.Asset)
There was a problem hiding this comment.
Updated the description of the pull request. I could make the PR green by switching everything to assetsfinder.
There was a problem hiding this comment.
If we will merge this, we also should remove the method controllers.Assets.versioned(String, Asset) and for that we will should mark it as @Deprecated in 2.9.x and 3.0.x
ihostage
reviewed
Jan 28, 2025
3ba91a6 to
24d539c
Compare
24d539c to
7de4f1b
Compare
7de4f1b to
138a51f
Compare
138a51f to
da7ebb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have two approaches for reverse routing public assets, both are described here:
This pull requests removes the first one by removing
StaticAssetsMetadata. Reason for removal is to remove all static/"global" state.However I am not sure if we really should merge this pull request.
Reason is, the first approach is a bit easier for people how do not care about a static state in their applications, like when you are working on a single Play instance and not plan to run multiple Play apps within one jvm.
I think if we just keep both approaches documented it should be ok.
Not sure yet.