feat: add install script #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
I got this error. yarn build |
|
@rogerznts on which yarn build and exact commit (Plasmic) does that happen? |
|
Thank you, this nice script 🚀 |
|
@kiyochinh does the script work for you? |
cunneen
reviewed
Jun 20, 2025
| continue | ||
| fi | ||
| echo "Building... $dir" | ||
| pushd platform/"$dir" |
There was a problem hiding this comment.
I got an error at this line:
Building... platform/canvas-packages
./install.bash: line 42: pushd: platform/platform/canvas-packages: No such file or directorySince $dir will already be prefixed with "platform/", I think this should be changed to:
echo "Building... $dir"
pushd "$dir"
cunneen
reviewed
Jun 20, 2025
| pushd platform/"$dir" | ||
| if [ -f package.json ]; then | ||
| if [ "\$(jq -r '.scripts.build' package.json)" != "null" ]; then | ||
| NODE_ENV=production yarn build |
There was a problem hiding this comment.
I get the following error at this line:
Building... platform/integration-tests
~/Development/plasmic/platform/integration-tests ~/Development/plasmic
yarn run v1.22.22
error Command "build" not found.I think this should be changed to remove the backslash on line 44, ie:
if [ -f package.json ]; then
if [ "$(jq -r '.scripts.build' package.json)" != "null" ]; then
NODE_ENV=production yarn build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the logic that our team derived from the the multi installations step and might be useful for others. Happy to simply also other parts of the community build process and deployment if you are interested in those.