many cosmetic improvements #31
Conversation
|
thanks for your great open-source contribution. |
| * Fixed a timezone issue with unit tests | ||
| * Upgrade prgx to 0.11.1 | ||
| * Reworked Dockerfile - multi-stage, better extension configuration, added a Makefile with 'all' and 'run' targets | ||
| * Improve README |
There was a problem hiding this comment.
None of these are user facing and need not be in Changelog.
There was a problem hiding this comment.
plz define user facing...
who is the user?
define "facing"
besides I kind of disagree, at least those two a "user facing" - if i get this definition right
- Upgrade prgx to 0.11.1
- Reworked Dockerfile - multi-stage, better extension configuration, added a Makefile with 'all' and 'run' targets
There was a problem hiding this comment.
Why would SQL users or admins care about these?
Makefile
Outdated
| docker build -t postgresql-ulid --build-arg="PG_MAJOR=16" . | ||
|
|
||
| run: | ||
| docker run -p 5432:5432 postgresql-ulid No newline at end of file |
There was a problem hiding this comment.
also, is the makefile really needed?
There was a problem hiding this comment.
that's a matter of preference and baseline
baseline - if you have the skills you can do it from memory
preference - it could be part of the doc
my feeling -> developers read code first, then the docs
|
I wonder why all these CI tests are failing all of a sudden |
|
Closing this for now. Please open once you get the tests working locally. |
0.1.4