-
Notifications
You must be signed in to change notification settings - Fork 29
Begin testing for PG18 (Beta 1) #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like the MSRV needs to change. As well, this should point to the |
It's an even bigger jump to 1.85.0, because pgrx has standardized on |
|
@pksunkara I believe this is ready for review. The changes I made attempted to keep disruptions to the existing code at minimum (hence the Docker Other than ec0ecf4, the important changes are:
The changes in lib were due to: Even though the imports were unused, I got another error after removing them: So I pulled in |
pksunkara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be willing to open a separate PR upgrading the edition to 2024 and rust to 1.85 as a first step towards 18 release?
I don't want to merge a next test, because it's not going to be the same for next release.
|
|
||
| edition = "2021" | ||
| rust-version = "1.81.0" | ||
| rust-version = "1.82.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 85 or 82?
| Self: Sized, | ||
| { | ||
| let bytes: &[u8] = FromDatum::from_polymorphic_datum(datum, is_null, typoid)?; | ||
| let bytes: &[u8] = unsafe { FromDatum::from_polymorphic_datum(datum, is_null, typoid)? }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What made this unsafe?
Yeah, let me do that. We can come back to this PR after that one is merged. 👍 |
|
Closing this as it will be cannibalized. |
Now that Postgres 18 (Beta 1) Dockerfiles are available, I think it would make sense to start testing against that version, and catch any potential issues before the official release.