This repository was archived by the owner on Aug 23, 2024. It is now read-only.
Handle HTTP 204 on a repo having no contributors #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if s isnt 200 | ||
| cb(new Error("Repo contributors error")) | ||
| else | ||
| cb null, b, h |
There was a problem hiding this comment.
Make the above 4 lines into a single one?
|
Please excuse my coffeescript. The sum total of all the coffeescript I've written in the world is in the PR's I've sent to this project, so at times it can be a little rough! |
pksunkara
added a commit
that referenced
this pull request
Feb 20, 2014
Handle HTTP 204 on a repo having no contributors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a repository has no contributors (it can happen!) the
/repo/x/y/contributorscall returns a 204, which Octonode translates into an error, whereas it should be a empty result.