This repository was archived by the owner on Aug 23, 2024. It is now read-only.
Change util-extend package for the deep-extend.
#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o request parameters get wiped during building request objects. Fixes pksunkara#89
|
Did you test this fix? |
|
I ran it through my app that does quite a few requests, but couldn't test any of the POST functionality if someone wants to give it a run. |
|
Read the code of |
pksunkara
added a commit
that referenced
this pull request
Jan 25, 2014
Change `util-extend` package for the `deep-extend`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure no request parameters get wiped during building request objects.
Fixes #89. I wrongly assumed that the
util-extendwas a deep copy. It isn't. This one is.