This repository was archived by the owner on Aug 23, 2024. It is now read-only.
Added ability to specify a proxy server for requests. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This meant refactoring how `request` options are put together and adds a new dependency on `utils-extend`
|
Have you tested this? |
|
Yes, on my machine using proxies and no proxies, but I don't have a very full implementation of the API to test every case against. Would be good if someone could give it a whirl first |
|
Could you test it with the following script? (The script sees your github hooks and asks you if you want to delete any) https://gist.github.com/pksunkara/7981618 I just want to make sure the addition of |
|
It ran fine and listed all zero hooks which I have access too. I can't test any more than that using the script. |
pksunkara
added a commit
that referenced
this pull request
Dec 30, 2013
Added ability to specify a proxy server for requests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will now respect environment proxy settings in
HTTP_PROXYThis meant refactoring how
requestoptions are put together and adds a new dependency onutils-extend, but it now means all of the options passed torequestare customisable