This repository was archived by the owner on Aug 23, 2024. It is now read-only.
Allow parameters in repo.updateContents #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
suggested changes
Oct 17, 2017
src/octonode/repo.coffee
Outdated
| updateContents: (path, message, content, sha, cbOrBranchOrOptions, cb) -> | ||
| content = new Buffer(content).toString('base64') | ||
| if !cb? and cbOrBranchOrOptions | ||
| cb = cbOrBranchOrOptions | ||
| cbOrBranch = 'master' |
There was a problem hiding this comment.
cbOrBranchOrOptions = 'master'
src/octonode/repo.coffee
Outdated
| cbOrBranch = 'master' | ||
| @client.put "/repos/#{@name}/contents/#{path}", {branch: cbOrBranch, message: message, content: new Buffer(content).toString('base64'), sha: sha}, (err, s, b, h) -> | ||
| if typeof cbOrBranchOrOptions is 'string' | ||
| param = {branch: cbOrBranchOrOptions, message: message, content: content} |
src/octonode/repo.coffee
Outdated
| if typeof cbOrBranchOrOptions is 'string' | ||
| param = {branch: cbOrBranchOrOptions, message: message, content: content} | ||
| else if typeof cbOrBranchOrOptions is 'object' | ||
| param = cbOrBranchOrOptions |
|
You haven't updated the JS lib. Also, please squash the commits into one. |
pksunkara
approved these changes
Oct 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the ability to pass optional parameters such as commiter and author to updateContents