This repository was archived by the owner on Aug 23, 2024. It is now read-only.
Fix Gist::delete #185
Merged
Fix Gist::delete #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No sorry. The client will be trying delete as long as it can. |
|
The following cases are causes infinite loop.
github = require('octonode')
github.client('badtoken').gist().delete('badid') |
|
You are right. Can you check if there are any other such retries and fix them too? |
|
I'll try. |
|
Please check the files changed. |
| @@ -131,8 +134,9 @@ class Gist | |||
| # Delete a comment | |||
| # '/gists/comments/1' DELETE | |||
| deleteComment: (id) -> | |||
|
Only one small thing which needs to be fixed. |
|
Thanks for the PR 😄 |
|
Thanks 😃 |
aki77
added a commit
to aki77/atom-gist
that referenced
this pull request
Jul 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add callback parameters.