This repository was archived by the owner on Aug 23, 2024. It is now read-only.
added redirect_uri parameter to authentication call (including lib folder) #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port different sub paths of the official callback)
| @@ -74,6 +74,7 @@ auth = module.exports = | |||
| uri+= "?client_id=#{@options.id}" | |||
| uri+= "&state=#{randomstring.generate()}" | |||
| uri+= "&scope=#{scopes.join(',')}" | |||
| if @options.redirect_uri then uri+= "&redirect_uri=#{@options.redirect_uri}" | |||
There was a problem hiding this comment.
Can you add return uri line in here? If you see the generated .js file, it looks like coffee-script is introducing a bug by doing return uri inside the if loop.
|
done. Very strange behaviour and nice catch on your end. |
|
Thanks for the PR. |
pksunkara
added a commit
that referenced
this pull request
Jun 12, 2015
added redirect_uri parameter to authentication call (including lib folder)
|
can you bump the version and republish? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github oauth supports different sub paths of the official callback: https://developer.github.com/v3/oauth/