This repository was archived by the owner on Aug 23, 2024. It is now read-only.
Add support for the GitHub Memberships check API #164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "octonode", | |||
| "version": "0.6.14", | |||
| "version": "0.6.15", | |||
There was a problem hiding this comment.
Don't do this please. I will make a separate commit.
|
Just one small thing. Remove that and I can merge this. Thanks for the PR 😄 |
|
Removed, sorry about that. Also, the Thanks for the great library! |
|
Could you squash that last commit into the first commit? It's just I like to keep the history a bit clean. |
|
Sorry I'm not going to be able to get back to this soon. I'll see if I can find the time though. |
|
I will do this locally then. Thanks for the PR. |
pksunkara
added a commit
that referenced
this pull request
Feb 27, 2015
Add support for the GitHub Memberships check API
|
Merged using command line. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the updates to the organization APIs on GitHub, there's a need for some new endpoints.
The https://developer.github.com/v3/orgs/members/#check-membership API is currently in opt-in preview, and requires a specific Accept header for that call. This PR adds the API and uses the existing getOptions client call to do so.
General info on the changes: https://developer.github.com/changes/2015-01-07-prepare-for-organization-permissions-changes/
Understand if you would rather wait until the API ships on the GitHub side without the requirement for the special header. I didn't find much test coverage on the org side so have not added any tests, sry.
Thanks.