This repository was archived by the owner on Aug 23, 2024. It is now read-only.
#122 Added pagination support for repo.commits. #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,8 +38,8 @@ class Repo | |||
|
|
|||
| # Get the commits for a repository | |||
| # '/repos/pksunkara/hub/commits' GET | |||
There was a problem hiding this comment.
Could you add the comments here?
# - page or query object, optional - params[0]
# - per_page, optional - params[1]| @@ -1,4 +1,4 @@ | |||
| // Generated by CoffeeScript 1.7.1 | |||
| // Generated by CoffeeScript 1.8.0 | |||
There was a problem hiding this comment.
Oh no. I haven't updated the library to 1.8 yet, please use 1.7.1 to generate the lib.
|
Sorry about this, but just a few minor nitpicks. |
|
No worries, let me downgrade coffee script so I can re-generate the files. |
- Added white space after params... - Re-generated js files with CoffeeScript 1.7.1
pksunkara
added a commit
that referenced
this pull request
Oct 7, 2014
#122 Added pagination support for repo.commits.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.