This repository was archived by the owner on Aug 23, 2024. It is now read-only.
Fixes crash for when @token is null
#143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```javascript typeof null // "object"``` leading to the subsequent operation -> `@{null}.username` which in turn throws:
```
TypeError: Cannot read property 'username' of null
```
|
It would give an error when |
|
I believe that the result of accessing a property on a "username".something // undefinedBefore submitting this PR I have run tests where @token was equal to the following values: { username: 'user', password: 'pass' } // "user:pass"
null // ""
1 // ""
{} // ""
undefined // ""
"string" // ""Which I believe is the expected behaviour? Let me know if not. |
pksunkara
added a commit
that referenced
this pull request
Oct 1, 2014
Fixes crash for when `@token` is `null`
pksunkara
added a commit
that referenced
this pull request
Oct 4, 2014
|
Any chance of a 0.6.8 release of this @pksunkara? I've tested it locally, and it seems to be working. |
|
@trevorah Done. Released v0.6.8 |
|
Thanks @pksunkara! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to:
Leading to the subsequent operation ->
@{null}.usernamewhich in turn throws: