这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Aug 23, 2024. It is now read-only.

Add pagination support to the repo.branches calls. #131

Merged
merged 1 commit into from
Aug 29, 2014

Conversation

joshrp
Copy link
Contributor

@joshrp joshrp commented Aug 27, 2014

Also includes commiting the built version of the patch command from #129

@@ -104,8 +104,8 @@ class Repo

# Get the branches for a repository
# '/repos/pksunkara/hub/branches' GET
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the pagination comments here?

   # - page or query object, optional - params[0]
   # - per_page, optional             - params[1]

@pksunkara
Copy link
Owner

Other than the comment, lgtm.

@joshrp joshrp force-pushed the branches-pagination branch from 676009d to 66584b6 Compare August 29, 2014 10:55
@joshrp
Copy link
Contributor Author

joshrp commented Aug 29, 2014

Sorted @pksunkara, thanks

@joshrp joshrp closed this Aug 29, 2014
@joshrp joshrp reopened this Aug 29, 2014
@joshrp
Copy link
Contributor Author

joshrp commented Aug 29, 2014

DAMN YOU CLOSE BUTTON!

pksunkara added a commit that referenced this pull request Aug 29, 2014
Add pagination support to the repo.branches calls.
@pksunkara pksunkara merged commit be2a061 into pksunkara:master Aug 29, 2014
@joshrp joshrp deleted the branches-pagination branch September 1, 2014 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants