This repository was archived by the owner on Aug 23, 2024. It is now read-only.
The documentation in the READMD was incorrect #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I forgot to change the README after the latest change in code |
pksunkara
added a commit
that referenced
this pull request
Mar 1, 2012
The documentation in the READMD was incorrect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's confusing when you don't specify where the client variable comes from, as one might think you had a typo.
And the worse is the documentation is wrong about what arguments the callback takes.
I just updated the readme, to reflect the code, so that newcomers have an easier time getting started.
Wil