This repository was archived by the owner on Aug 23, 2024. It is now read-only.
Added create/delete users from teams, list repos of a team and create teams #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First attempt.
User can now add, delete users from a team and list repos of a team.
You can now create teams. Yay.
You can now create teams. yay.
rmUser, newTeam, repos, createTeam
I was just messing around, forgot that I had committed it.
| @@ -31,6 +31,28 @@ class Team | |||
| @client.get "/teams/#{@id}/members/#{user}", (err, s, b, h) -> | |||
| return cb(err) if err | |||
| cb null, s is 204, h | |||
|
|
|||
| # Add a user to a team (must have admin permissions to do so) | |||
|
Thanks for the pull request. 😄 Could you check my comments on the diff and fix them? Also please update README accordingly. Thanks |
Removed two lines at the bottom
Removed a line here or there, and renamed newUser to addUser, and rmUser to removeUser.
|
OK, I think that's everything. |
pksunkara
added a commit
that referenced
this pull request
Apr 2, 2014
Added create/delete users from teams, list repos of a team and create teams
|
Very sorry, seems that I have given you the wrong version, the correct one must have been lost somewhere... For now I can't get to my repo because there is some 'maintenance going on', but I will get the correct version to you ASAP. Nothing major, but currently some of my implementations don't work. Sorry about this. |
|
hmm.. I checked the code. Didn't find any mistakes. Haven't tested it though. Could you fix them and send me PR again? Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also compiled it and changed the documentation. Please do point out if I made a mistake somewhere 😄