This repository was archived by the owner on Sep 18, 2024. It is now read-only.
Ensure camelize respects first_letter_in_uppercase #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
added a commit
that referenced
this pull request
Aug 4, 2013
Ensure camelize respects first_letter_in_uppercase
|
I will push it soon. |
|
Thanks! |
|
Published v0.3.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have encountered an inconsistency in the
camelize()method.If it is passed a string with an UppercaseFirstLetter but the second argument
first_letter_in_uppercaseis passed in asfalse, result is returned without ensuring the first letter is lower-cased.Although the main use case appears to be changing underscore_words to camelCase, I am using it to convert paths (e.g.
My/Path/To/Somethingshould becomemyPathToSomething) in which case the first word is not ensured to start with a lowercase letter.This changeset fixes the issue, and I've added this to the test suite.
Hope you accept the change & update npm soon.
Thanks,
Jed.