Always update workspace Cargo.toml
#197
Conversation
Was previously only updated when at least one package uses common version. However, one can specify dependencies in `workspace.dependencies`, which was not updated when all packages use independent versions. This changes the behavior to always update workspace `Cargo.toml`.
|
I'm sorry, but could you please clarify a bit more? I'm quite confused about the issue you're experiencing. Please leave a detailed example in a comment, explaining what's happening with the current version versus what's expected. |
|
Sure. As an example, I have created a workspace with three crates [workspace.dependencies]
a = {path = "a", version="0.0.0"}
b = {path = "b", version="0.0.0"}
c = {path = "c", version="0.0.0"}When I now run $ cargo workspaces version --no-git-commit -y minor
Changes:
- a: 0.0.0 => 0.1.0
- b: 0.0.0 => 0.1.0
- c: 0.0.0 => 0.1.0
error: failed to select a version for the requirement `a = "^0.0.0"`
candidate versions found which didn't match: 0.1.0
location searched: /path/to/example/a
required by package `b v0.1.0 (/path/to/example/b)`
info success okresulting in the following diff: diff --git a/a/Cargo.toml b/a/Cargo.toml
index ec6df27..cffa73a 100644
--- a/a/Cargo.toml
+++ b/a/Cargo.toml
@@ -1,6 +1,6 @@
[package]
name = "a"
-version = "0.0.0"
+version = "0.1.0"
edition = "2024"
[dependencies]
diff --git a/b/Cargo.toml b/b/Cargo.toml
index 410485f..7f12d6b 100644
--- a/b/Cargo.toml
+++ b/b/Cargo.toml
@@ -1,6 +1,6 @@
[package]
name = "b"
-version = "0.0.0"
+version = "0.1.0"
edition = "2024"
[dependencies]
diff --git a/c/Cargo.toml b/c/Cargo.toml
index 610480a..4afede4 100644
--- a/c/Cargo.toml
+++ b/c/Cargo.toml
@@ -1,6 +1,6 @@
[package]
name = "c"
-version = "0.0.0"
+version = "0.1.0"
edition = "2024"
[dependencies]Note that the workspace's When doing the same with this PR merged, I instead get the following output: $ cargo workspaces version --no-git-commit -y minor
Changes:
- a: 0.0.0 => 0.1.0
- b: 0.0.0 => 0.1.0
- c: 0.0.0 => 0.1.0
Locking 3 packages to latest Rust 1.85.0 compatible versions
Updating a v0.0.0 (/path/to/example/a) -> v0.1.0
Updating b v0.0.0 (/path/to/example/b) -> v0.1.0
Updating c v0.0.0 (/path/to/example/c) -> v0.1.0
info success okand the following diff: diff --git a/Cargo.lock b/Cargo.lock
index 2497d4a..90b7477 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -4,18 +4,18 @@ version = 4
[[package]]
name = "a"
-version = "0.0.0"
+version = "0.1.0"
[[package]]
name = "b"
-version = "0.0.0"
+version = "0.1.0"
dependencies = [
"a",
]
[[package]]
name = "c"
-version = "0.0.0"
+version = "0.1.0"
dependencies = [
"a",
"b",
diff --git a/Cargo.toml b/Cargo.toml
index ae76085..01dcca1 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -7,6 +7,6 @@ members = [
]
[workspace.dependencies]
-a = {path = "a", version="0.0.0"}
-b = {path = "b", version="0.0.0"}
-c = {path = "c", version="0.0.0"}
+a = {path = "a", version="0.1.0"}
+b = {path = "b", version="0.1.0"}
+c = {path = "c", version="0.1.0"}
diff --git a/a/Cargo.toml b/a/Cargo.toml
index ec6df27..cffa73a 100644
--- a/a/Cargo.toml
+++ b/a/Cargo.toml
@@ -1,6 +1,6 @@
[package]
name = "a"
-version = "0.0.0"
+version = "0.1.0"
edition = "2024"
[dependencies]
diff --git a/b/Cargo.toml b/b/Cargo.toml
index 410485f..7f12d6b 100644
--- a/b/Cargo.toml
+++ b/b/Cargo.toml
@@ -1,6 +1,6 @@
[package]
name = "b"
-version = "0.0.0"
+version = "0.1.0"
edition = "2024"
[dependencies]
diff --git a/c/Cargo.toml b/c/Cargo.toml
index 610480a..4afede4 100644
--- a/c/Cargo.toml
+++ b/c/Cargo.toml
@@ -1,6 +1,6 @@
[package]
name = "c"
-version = "0.0.0"
+version = "0.1.0"
edition = "2024"
[dependencies]Note how now there is no error and the version has correctly been updated in the workspace' s Let me know if you have any further questions. |
Currently, the workspace's
Cargo.tomlis only updated when at least one crate uses common versioning.However, one can specify dependencies in
workspace.dependencies, which is currently not updated when all packages use independent versioning.This PR changes the behavior to always update the workspace's
Cargo.toml, updating the versions of workspace-crates.