chore: Add release workflow to publish binaries #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new GitHub Actions workflow to automate releasing binaries.
- Adds a release job that creates a GitHub release from semantic version tags.
- Implements an upload_binaries job with a matrix for building and uploading binaries for Ubuntu, macOS, and Windows.
|
The current platforms you have are good enough. It looks good enough and I don't see any issues. I am going to merge this but will ping you if I see any issues on the first release. |
|
Fantastic! Thank you for getting this in so quickly. Please do ping me if there are issues! I also wanted to say that this tool is really useful! I'm working on integrating it to release https://github.com/holochain/holochain and its libraries. Still a work in progress, but just in case you were interested in what I'm up to with your project :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the best of my ability to test this, this is a solution to the issue #194
Following the existing release process (assumed) for this repository, of publishing a new version to crates.io and then creating+pushing a Git tag - the new workflow will take over from there. The workflow creates a new GitHub release and attaches binaries for Ubuntu, MacOS and Windows.
I've followed the instructions over here to test that binstall will find the uploaded assets https://github.com/cargo-bins/cargo-binstall/blob/main/SUPPORT.md. By uploading a binary with the same naming format to a release on a repository I own. But I can't do that here.
A few outstanding questions:
ubuntu-latestto work, because I want to use this on CI, but I see in your CI workflow that more platforms are tested and supported. Does it matter to create binaries for those other platforms now or should they be added if requested?cargo-workspacesandcargo-ws. Again, because my use-case is CI, I prefer having the full name and no ambiguity about what tool is being used. I totally get that a user who is using this tool manually might want less typing. So are binaries for both names wanted?Happy to add more to this PR, but I think it does what I need. I'm thinking that adding more than that initially just slows down CI and it's maybe okay to let people open issues as they need more, but I'll leave these questions open!