Add since option to version #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
pksunkara
commented
May 27, 2025
- Fix issues with recent changes in changed
- Remove include-merged-tags option
- Added since option to version
- Consistent value names in help msg
There was a problem hiding this comment.
Pull Request Overview
Adds a --since flag to versioning commands, removes the deprecated include-merged-tags option, and normalizes CLI parameter names to uppercase across help messages and documentation.
- Introduce
sinceoption in changable and version logic - Remove
include-merged-tagsentirely - Update all
value_nameattributes (and README/CHANGELOG) to use uppercase identifiers
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/version.rs | Added handling for self.change.since, defaulting to last tag and passing it into package diff |
| src/utils/git.rs | Normalized value_name for several options to uppercase (PATTERN, PREFIX, REMOTE) |
| src/utils/changable.rs | Removed include_merged_tags, added since field and special-case for no-tag in ChangeData |
| src/exec.rs | Normalized value_name for ignore to uppercase |
| src/changed.rs | Switched self.since references to self.change.since |
| README.md | Updated CLI examples to [OPTIONS], uppercase PATTERN/IDENTIFIER, and added --since |
| CHANGELOG.md | Moved 0.4.0 to “Unreleased” and documented removed flags and new since option |
Comments suppressed due to low confidence (1)
cargo-workspaces/src/utils/version.rs:85
- There are no tests covering the new
--sincelogic indo_versioning; consider adding unit or integration tests to verify filtering by a customsinceref.
let mut since = self.change.since.clone();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.