这是indexloc提供的服务，不要输入任何密码
Skip to content

fix #153: create command now works with newer cargo versions #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2024
Merged

fix #153: create command now works with newer cargo versions #152

merged 2 commits into from
May 27, 2024

Conversation

sushruth
Copy link
Contributor

@sushruth sushruth commented May 27, 2024 •
edited
Loading

I am not sure which exact version of cargo this happens on but create command fails in cargo 1.78.0 because Created is not present in stderr. However, Adding is present as in this example -

❯ cargo new --name foo --lib --edition 2021 lib/foo
    Creating library `foo` package
      Adding `foo` as member of workspace at `/home/sushruth/code/moarr`
note: see more `Cargo.toml` keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

This PR tries to improve that check instead of crashing when there is no issue. (Fix for #153)

I am a beginner to rust so please help me make this fix better.

@sushruth sushruth changed the title fix: create now works with newer cargo versions fix: #153 create command now works with newer cargo versions May 27, 2024
@sushruth sushruth changed the title fix: #153 create command now works with newer cargo versions fix #153: create command now works with newer cargo versions May 27, 2024
@sushruth sushruth mentioned this pull request May 27, 2024
Open
@pksunkara pksunkara linked an issue May 27, 2024 that may be closed by this pull request
Create command errors out probably in new versions of cargo #153
Closed
pksunkara
pksunkara reviewed May 27, 2024
View reviewed changes
@pksunkara pksunkara merged commit 40f8c3f into pksunkara:master May 27, 2024
@sushruth
Copy link
Contributor Author

@pksunkara Thanks! when do you plan on releasing this change?

@pksunkara
Copy link
Owner

Released 0.3.2

@sushruth
Copy link
Contributor Author

sushruth commented Jun 4, 2024

@pksunkara Sorry I had one more question - when would the new version be available in the nix packages registry?

@pksunkara
Copy link
Owner

Hey, I don't maintain that. You would have to ask whoever authored it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create command errors out probably in new versions of cargo
2 participants
@sushruth @pksunkara