Simplify derive #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
requested changes
May 12, 2020
|
|
||
| quote! { | ||
| #new | ||
| struct #ident { |
There was a problem hiding this comment.
We are missing DeriveInput's, attrs, vis, generics. I remember I didn't do it like this because tokenising generics was a bit difficult because you have to put it's types at one point and it's where clause at other.
There was a problem hiding this comment.
I definitely like the PR, but this is a blocker.
|
Moving away from the derive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need the derive at all, but nonetheless, this code insults my sense of beauty. Let's fix it for the sake of history.