θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

Conversation

@Abdulgafar4
Copy link
Contributor

πŸ“˜ Pull Request Template – PhysicsHub

Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.


πŸ” Description

This PR fixes critical visibility issues with Stars components across pages and the homepage radial glow in dark mode, while also implementing a proper React project structure with centralized layout management.

Key Improvements:

  • Fixed Stars Visibility: Updated Stars components to use #AEE3FF, ensuring proper visibility in both light and dark modes
  • Fixed Homepage Glow: Resolved z-index and transparency issues preventing the radial glow from showing in dark mode on the homepage
  • Proper React Architecture: Refactored to use a centralized Layout component instead of duplicating Header/Footer on every page
  • Fixed Footer Positioning: Ensured footer stays at the bottom on all pages using proper flexbox layout

Closes #15 (if applicable)


βœ… Checklist

Before requesting a review, please ensure that you have:

  • Verified that the project builds and runs locally (npm run dev)
  • Ensured no ESLint or TypeScript warnings/errors remain
  • Updated documentation, comments, or in-code explanations where needed
  • Verified responsiveness across devices (desktop, tablet, mobile)
  • Updated version in package.json as specified on CONTRIBUTING.md
  • Followed the CONTRIBUTING.md guidelines

🎨 Visual Changes (if UI-related)

Screenshot 2025-10-18 at 12 56 11β€―AM Screenshot 2025-10-18 at 12 56 26β€―AM Screenshot 2025-10-18 at 12 56 38β€―AM Screenshot 2025-10-18 at 12 56 51β€―AM

πŸ“‚ Type of Change

  • πŸ› Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to change)
  • πŸ“ Documentation update
  • ♻️ Refactor / code quality improvement
  • 🎨 UI/UX enhancement
  • πŸ”’ Security improvement

🧩 Additional Notes for Reviewers

Abdulgafar Temitope Tajudeen added 2 commits October 17, 2025 23:50
…rom individual pages, and integrate a new Layout component for consistent styling
@Abdulgafar4 Abdulgafar4 changed the title Issue 15 [Bug]: Light theme is broken. #15 Oct 18, 2025
@physicshub
Copy link
Owner

Hey @Abdulgafar4 well done, now it should work good, I'll merge your PR, but can you resolve the conflicts first? There are some changes that you didn't pull. Also can you update the version in package.json?

@Abdulgafar4
Copy link
Contributor Author

Alright I'll resolve the conflict and update the package

@physicshub physicshub merged commit 664150c into physicshub:main Oct 18, 2025
@physicshub
Copy link
Owner

@all-contributors add @Abdulgafar4 code

@allcontributors
Copy link
Contributor

@physicshub

I've put up a pull request to add @Abdulgafar4! πŸŽ‰

@physicshub
Copy link
Owner

@all-contributors add @Abdulgafar4 design

@allcontributors
Copy link
Contributor

@physicshub

I've updated the pull request to add @Abdulgafar4! πŸŽ‰

@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.0.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Light theme is broken.

2 participants