Add options for resolv.conf #4040
Conversation
jim-p
left a comment
There was a problem hiding this comment.
I don't like the idea of a free-form text field for this, especially not on a page that only contains basic options.
Ideally, it should be separated out into GUI knobs for each possible option, or it needs to be moved somewhere under Advanced options.
|
I agree with you, the place to be for this is in "Advanced options", Even if we can be exhaustive in the options we purpose by this feature, it will make it very hard to manage and maintain. |
|
Switched to "Advanced options Network" page. |
rbgarga
left a comment
There was a problem hiding this comment.
system_resolvconf_generate() must be called when the content of $config['system']['resolvconfoptions'] changes, otherwise the items will not be added to resolv.conf when user click Save
| } | ||
|
|
||
| // Add options | ||
| if (isset($config['system']['resolvconfoptions']) && !empty($config['system']['resolvconfoptions'])) { |
There was a problem hiding this comment.
empty() already checks if variable is set, you can remove isset() call from here
| unset($config['system']['resolvconfoptions']); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Do not add lines with only spaces like 182 and 183
| $config['system']['resolvconfoptions'] = base64_encode(trim($_POST['resolvconfoptions'])); | ||
| } else { | ||
| unset($config['system']['resolvconfoptions']); | ||
| } |
There was a problem hiding this comment.
This block indentation is wrong. Please use hard tabs with size 8
|
Closing after almost one year with no activity. @joshuasign if you want to work on this change again please re-submit |
Uh oh!
There was an error while loading. Please reload this page.