Allow specific gateways to be excluded from default gatway switching #3609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a feature to allow you to optionally prevent gateways from being chosen as default during Gateway Switching operations in a multi-WAN environment when the "Enable default gateway switching" option is enabled. Changes/new features - adds a `no_defgw_switch` flag to gateway config that will cause a gateway to be excluded from the defgw selection process - indicate this setting (as an icon) in the System > Gateway list view - updated help text for Default gateway switching in System > Advanced > Misc to better describe the use of the function - adds some debug logging for gw change events - selecting a gw as the default gw automatically hides this option, as having the 2 both enabled does not make sense - added input validation to automatically disable the no_defgw_switch bool when saving a gw as default from the GUI Files changed: /etc/inc/gwlb.inc /usr/local/www/system_advanced_misc.php /usr/local/www/system_gateways.php /usr/local/www/system_gateways_edit.php
luckman212
added a commit
to luckman212/pfsense
that referenced
this pull request
Mar 30, 2017
luckman212
added a commit
to luckman212/pfsense
that referenced
this pull request
Mar 30, 2017
luckman212
added a commit
to luckman212/pfsense
that referenced
this pull request
Mar 30, 2017
Contributor
Author
|
I had to out of necessity create a version of this patch that applies cleanly to 2.3.3. In case anyone needs it and missed it in the commits, you can apply it from: 87d5f65 |
Member
|
Can you please rebase your fork? |
Contributor
Author
|
Yes, will do today. I'm sorry, I have been terribly backlogged last few weeks. |
Contributor
|
Made a different pullrequest which allows the same (disabling a gateway to become the default) and also setting priorities for the others, #3757 |
Contributor
|
Please resolve the conflict |
Contributor
luckman212
added a commit
to luckman212/pfsense
that referenced
this pull request
Sep 23, 2017
Rebase of my old PR pfsense#3609
Contributor
Author
|
I rebased/rewrote this - new PR is #3827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a feature to allow you to optionally prevent gateways from being chosen as default during Gateway Switching operations in a multi-WAN environment when the "Enable default gateway switching" option is enabled. Some possible use cases:
This only controls the default gateway of the firewall itself; it does not change the behavior of Policy Based Routing.
Changes/new features
no_defgw_switchflag to gateway config that will cause a gateway to be excluded from the default gw selection processno_defgw_switchbool when saving a gateway you've marked as default from the GUI)Files changed:
/etc/inc/gwlb.inc
/usr/local/www/system_advanced_misc.php
/usr/local/www/system_gateways.php
/usr/local/www/system_gateways_edit.php