这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix some file extension issues with image and image sequence export #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

Fix some file extension issues with image and image sequence export #1943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05a3018
Skip hasValidSuffix check if no filters are used
scribblemaniac Oct 28, 2025
405756f
Handle image export format and extension the same as image sequence e…
scribblemaniac Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions app/src/actioncommands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,39 @@ Status ActionCommands::exportImage()
QString exportFormat = dialog->getExportFormat();
bool useTranparency = dialog->getTransparency();

QString extension = "";
QString formatStr = exportFormat;
if (formatStr == "PNG" || formatStr == "png")
{
exportFormat = "PNG";
extension = ".png";
}
if (formatStr == "JPG" || formatStr == "jpg" || formatStr == "JPEG" || formatStr == "jpeg")
{
exportFormat = "JPG";
extension = ".jpg";
useTranparency = false; // JPG doesn't support transparency, so we have to include the background
}
if (formatStr == "TIFF" || formatStr == "tiff" || formatStr == "TIF" || formatStr == "tif")
{
exportFormat = "TIFF";
extension = ".tiff";
}
if (formatStr == "BMP" || formatStr == "bmp")
{
exportFormat = "BMP";
extension = ".bmp";
useTranparency = false;
}
if (formatStr == "WEBP" || formatStr == "webp") {
exportFormat = "WEBP";
extension = ".webp";
}
if (!filePath.endsWith(extension, Qt::CaseInsensitive))
{
filePath += extension;
}

// Export
QString sCameraLayerName = dialog->getCameraLayerName();
LayerCamera* cameraLayer = static_cast<LayerCamera*>(mEditor->layers()->findLayerByName(sCameraLayerName, Layer::CAMERA));
Expand Down
2 changes: 2 additions & 0 deletions app/src/filedialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,8 @@ QString FileDialog::saveFileFilters(FileType fileType)

bool FileDialog::hasValidSuffix(const QString& filters, const QString& filePath)
{
if (filters.isEmpty()) return true;

QString fileName = QFileInfo(filePath).fileName();
for (const QString& filter : filters.split(";;"))
{
Expand Down