Fix inaccessible top menu bar items #1933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The menu was being blocked by empty QWidgets from the title bars. By default, the title bar is shown and the empty title bar is hidden. They are then shown and hidden by QDockWidget::setTitleBarWidget. The parent widget of the titles bars was also changed to the QDockWidget as that is more logical and assures that the title bars are deleted if the BaseDockWidget is deleted.
MrStevns
approved these changes
Sep 20, 2025
chchwy
approved these changes
Sep 20, 2025
Member
|
OK, I will merge this PR and cherry pick to the release branch. |
Member
|
I just realized that this PR is for master. don't need to cherry-pick to |
Member
|
Ah... 😅 you're right.. in that case i've changed the milestone to 0.8.0 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseDockWidget was creating empty QWidgets that were children of the main window. As children of the main window they were positioned at the top left of the window by default and I guess they were being set to visible when the main window is shown. These didn't render anything because they're empty, but were blocking mouse events for a small area.
By hiding them right away, we prevent this behavior. I also changed the parents of the title bar widgets to be the BaseDockWidget, so they will be moved to the top left of the dock widget instead. I think the BaseDockWidget makes more sense as a parent logically and assures that if the BaseDockWidget is deleted, its title bars will be deleted right away too (the dock widgets currently last the lifetime of the application so this won't make any different right now).
Fixes #1929