Apply transformation before changing keyframe or layer #1936
+31
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because some tests uses these functions as well and they don't have a selection manager initialized
5f9f1e9 to
535b6d2
Compare
Member
|
Thanks & Good job @MrStevns I am going to merge this into 0.7.1 branch. Would you like I cherry pick your fix to the master branch or you plan to do a more proper fix? |
Member
Author
|
I am working on reworked model for how we interact with a selection and where the state lives. That upcoming PR should ensure that this workaround becomes obsolete, as such I don't think you need to cherry pick those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've dabbled with a few solutions and this is the least invasive fix I could come up with.
Fixes a bug where if you had a selection and the image had been transformed, then scrubbing to a different frame would make the new frame inherit the effect.
Before:
After:
Some users mentioned that this was particularly annoying when scrubbing between frames without explicitly deselecting.
I should mention i'm not fond of adding arbitrary logic to core functions like setLayerIndex and scrubTo. Ideally I would like to maintain the state of the selection and transform as well, by tying the selection to the keyframe but that's a far more invasive which makes no sense for a hotfix release.