Fix SoundManager calculating frame length incorrectly #1918
Conversation
scribblemaniac
left a comment
There was a problem hiding this comment.
I was going to look at this last weekend but got sidetracked by some tablet issues. The durations do make more sense if you consider that user typically animates at 8 fps, which would result in a frameLength of 0.8 for 0.1s, and 1.76 for 0.22s. I could reproduce the user's problems with moving and deleting the keyframes and even found an additional crash during playback. This appears to fix all of those issues 🌟
Good to go 👍
|
I was just reminded.. we should ideally be updating the changelog file on every bugfix or improvement we make, so we don't have to do it in bulks like last time. I've already accumulated the ones I found here: but given how long that PR has been lying there now.. I should have made a separate PR for that task |
SoundManager duplicates SoundClip’s length calculation but without taking the ceil() of the calculated length. This can result in a length of 0 for very short clips, essentially preventing interaction with them. To avoid this, reuse SoundClip’s recalculation mechanism. I believe this is the might be the same issue as reported in this forum post, though the specific durations given don’t particularly make sense to me.