Add "replace paper with transparency" dialog #1903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: CandyFace <CandyFace18@gmail.com> Co-authored-by: Jakob Gahde <j5lx@fmail.co.uk>
- Group preview options with preview area - Group apply options with apply button - Replace homegrown button box with standard component
J5lx
added a commit
that referenced
this pull request
Feb 15, 2025
* Add "add transparency to paper" dialog * Fix parameter name mismatch * Remove dead/redundant signals * Add missing license notices * Remove redundant layout from add transparency to paper dialog * Improve add transparency to paper UI - Group preview options with preview area - Group apply options with apply button - Replace homegrown button box with standard component * Reuse existing QDialog behaviours * Remove redundant layout from add transparency to paper dialog * Reuse existing autosave suppression pattern * Fix add transparency to paper dialog potentially outliving main window * Improve naming and capitalisation consistency * Wrap transparency to paper apply options in group box * Fix duplicate menu entry * Pass threshold as argument * Remove redundant condition * Don't take clipboard detour when adding transparency to paper * Rename "add transparency to paper" to "replace paper with transparency" --------- Co-authored-by: CandyFace <CandyFace18@gmail.com> Co-authored-by: Jakob Gahde <j5lx@fmail.co.uk>
Member
Author
|
Merged manually in 72cf028. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a split of the "add transparency to paper" portion of #1178. Although it is related to the advanced colouring feature of that PR, its implementation is pretty much independent, so I’m splitting it out to slim down the other PR. It’s also pretty trivial to temporarily disable this functionality if necessary.
As this PR is simply a part of my own review, it is not meant to be reviewed separately. I’m creating this mainly to skim over the changes one final time and to leave a public record of my review, and I’ll merge it myself in a moment.