Write tool properties to disk when calling leavingThisTool() or ~ToolManager() #1904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chchwy
approved these changes
Feb 15, 2025
|
I think I should go ahead and remove the changes in #1853 as well since it's now redundant |
chchwy
approved these changes
Feb 19, 2025
1a7a757 to
90f75d3
Compare
90f75d3 to
125486a
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool properties are written to disk immediately when changed. If you try to slide a scalar value with a high temporal resolution device like a tablet or a high end mouse, the flooding events will cause the program to freeze/lag as it struggles to write every value to the QSettings object.
Previously #1853 was merged to mitigate this problem with quick sizing, but if you change the properties on the tool options panel, the lag is still there.
This PR makes the change so that the program will wait until you switch to another tool, or close the program, to write everything onto the disk.