-
Notifications
You must be signed in to change notification settings - Fork 293
Reposition frame dialog: fix cancel button not working #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reposition frame dialog: fix cancel button not working #1928
Conversation
|
Hmm odd.. the tests work when i run it on my intel mac and use Qt 6. though i'm still on Monterey... |
17ec409 to
b048866
Compare
|
Looks like it could be a similar issue to one I debugged last year caused by certain directories in the data dir path being symlinked in macOS. You should look at |
|
Hmm yes that seems to be the case. I figured that out a few moments ago, thanks :D It's a bit difficult to debug when it works on my machine though.. the strange thing is that the layer_bitmap test works while the layer_sound fails. I'll look deeper into that function. |
|
I decided to use validateDataPath for the comparison rather than QDir.filepath, so the paths are resolved correctly. It fixes the tests... but is it correct? Alternatively I could have done |
8b4c8b7 to
ae4f06b
Compare
|
I've reverted the test changes again as a better fix is provided by #1932 |
ae4f06b to
455b1de
Compare
…button-reposition-frame-dialog
|
Thanks for catching this! |
No description provided.