#1922 Implement macOS codesign & notarization #1927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, this PR implements macOS code signing and notarization in the GitHub Action when creating the Pencil2D macOS app.
Issue: #1922
This ensures we meet Apple's security requirements and provide a better user experience, particularly to avoid the very annoying security warning.
This codesign & notarization process requires 6 GitHub actions secrets to work. I have added them to our repo.
If you don't have them, don't worry the notarization step will be skipped, and it will just work the same as before.
For anyone who wants to code-sign the app with your own Apple developer account, you need to
And then set the following GitHub Action secrets
P12_BASE64: the private key base64 text you just export aboveP12_PASSWORD: the custom password you set when you export the .p12 private keyAPPLE_ID: your Apple Developer account emailAPPLE_ID_PASSWORD: This is the "App-specific password", not the password you use to log into your Apple Developer account. Please request one on the developer website.APPLE_TEAM_ID: type the security command below to find itCODESIGN_CERT_IDENTITY: type the security command below to find itsecurity find-identity -v -p codesigningit will print out something like this: