Fix emtpy frame on position 1 when duplicating layer #1744
Conversation
|
Agreed, the min 1 keyframe per layer is a mess and causes all kinds of problems. There are also problems with simply removing it, because the undo stack is not notified (nor should it because you as a user didn't cause the action), yet you want to restore the data on the frame later, making it tricky to recover without having logic split several places. |
|
I added the new function you suggested. I’m not sure I entirely understand your comment about the undo stack, though. Are you saying that we should pay attention to this when we eventually add proper undo/redo support or to adjust the current system in some way? |
It was just a note that I felt like adding at the time, but yes I suspect that we'll have to make changes to make the undo/redo system work properly when that time come. I didn't mean that we should adjust it to the current system. The less places and more consistent we can make the min 1 keyframe pr layer, the better. I will merge the PR now, thanks for your work 😄 |
As reported by Nelphy on Discord. I also thought about renaming loadKey()… fundamentally, it’s more general-purpose than what we’re using it for so far IMO.
In the future, I think we should reconsider how we enforce the “min. one keyframe per layer” requirement. It’s a bit inconsistent right now with different assumptions made in different places, which is fundamentally what led to this issue.