这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix truncated playback for converted audio clips on Windows #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Fix truncated playback for converted audio clips on Windows #1733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions app/src/actioncommands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,10 @@ Status ActionCommands::importSound(FileType type)
{
st = Status::CANCELED;
}
else if (strSoundFile.endsWith(".wav"))
{
st = mEditor->sound()->loadSound(key, strSoundFile);
}
else
{
// Convert even if it already is a WAV file to strip metadata that the
// DirectShow media player backend on Windows can't handle
st = convertSoundToWav(strSoundFile);
}

Expand Down
2 changes: 1 addition & 1 deletion core_lib/src/movieimporter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ Status MovieImporter::importMovieAudio(const QString& filePath, std::function<bo

QString audioPath = QDir(mTempDir->path()).filePath("audio.wav");

QStringList args{ "-i", filePath, audioPath };
QStringList args{ "-i", filePath, "-map_metadata", "-1", "-bitexact", audioPath };

status = MovieExporter::executeFFmpeg(ffmpegLocation(), args, [&progress, this] (int frame) {
Q_UNUSED(frame)
Expand Down