Switch away from last layer before deleting it #1730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrStevns
approved these changes
Oct 16, 2022
Member
MrStevns
left a comment
There was a problem hiding this comment.
Changes looks good to me, you're right.. this must has been a bug for a while but just recently exposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where, when deleting the last layer, the layer deletion was performed before actually switching away from the layer so that, for a brief moment, the current layer didn’t actually exist. This issue must have been around for a while, but it was recently exposed through the addition of the onCurrentLayerWillChange signal in #1724. Unfortunately I missed that while reviewing the PR, so on current master this bug means that deleting the last layer while it is active will actually result in a bunch of assertions to fire before the program ultimately crashes.