Removed two lines of code that made the software crash #1684 #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scribblemaniac
approved these changes
Jan 14, 2022
Member
scribblemaniac
left a comment
There was a problem hiding this comment.
Looks good. Pointless lines and should not be called if camera1 or camera2 can be nullptr. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that since the camera is born with a EasingType, there was no need to add it, so the two lines of code, that made the software crash under certain circumstances, have been deleted.
The function containing the two lines of code is heavily improved in a PR #1587, and this PR is hopefully merged into the master branch soon, so just deleting the two lines of code if sufficient now, in my opinion.
Solves #1684