Upgrade Linux builds to Xenial and Qt 5.15 #1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note for the release notes: This means no more support for Linuxes older than Xenial.
|
I have no problem with the Qt version upgrade. If I recall correctly, we didn't move away from Ubuntu 14 is because AppImage refuses to package the binaries on newer versions of Ubuntu. If AppImage is fine now, that's a good move to upgrade. |
|
Let's merge this and see how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to ditch Trusty, it seems! The code changes in this PR aren’t that interesting, the main focus for review should be testing the build and making sure all those different dependency versions don‘t cause any regressions (especially for multimedia, since I switched from an unofficial PPA to Ubuntu’s official repositories there). Personally, I haven’t found any issues during my brief test, in fact it confirmed my suspicion that a newer Qt version would finally fix #1017 for good. With any luck, it might also fix some of the other Linux issues such as #1032 which we’ve never been able to reproduce. Still, I think it would be good to have it tested on more systems than just my own.
BTW, I noticed that the AppImage gets noticeably larger with this change. Probably due to additional dependencies being pulled in or something, but I haven’t been able to look into it yet. I don’t want to block this PR over that since this upgrade is necessary to get our Linux builds working again.
I also noticed that macOS runners on GHA actually have 3 cores rather than 2 like the Windows and Linux runners, so I adjusted the MAKEFLAGS accordingly.