这是indexloc提供的服务,不要输入任何密码
Skip to content

Toolbars #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Toolbars #1468

merged 5 commits into from
Jun 8, 2022

Conversation

chchwy
Copy link
Member

@chchwy chchwy commented Sep 16, 2020

An initial PR of adding Toolbars. The toolbars are in a basic usable level that having only essential/frequently used items.
I want to bring it up early for your attention and discussion. More features/PRs will come later on.

Currently, there are 3 toolbar sections:

  1. Main toolbar: New, Open, Save, Cut, Copy, Paste, Undo, Redo
  2. View toolbar: Zoom in/out, Reset view, Flip horizontal/Vertical
  3. Overlay toolbar: Show/hide Grid

You can show/hide each of the toolbars under Windows menu.

Implementing toolbars have two goals:

  1. Addressing Request a toolbar so can do Copy/Paste/Undo without keyboard #1047 & Implement a Customizable toolbar for screen tablet users #1455 for touch screen users to easily access menu features (e.g., Undo/Redo) without a keyboard.
  2. Addressing Incorrectly overlapped panel layout contents on interface resizing #1417, to efficiently utilize UI space for low res display users. It's meant to replace DisplayOptions with View/Overlay Toolbars. (not done yet, will come later on)

toolbars

BTW, toolbars can be snap to any side of the main window, not only the top area.
snap-left

@chchwy
Copy link
Member Author

chchwy commented Sep 16, 2020

And note: some of the menu items don't have icons. We probably need to make them.

@Jose-Moreno
Copy link
Member

@chchwy Nice work. A quick note on #1455 that issue meant to be requesting an empty, fully customizable widget (I called it a toolbar but it could be a panel) that people can modify according to their preference and allow them to place any action available on Pencil2D menus or other panels as a quick access. In that sense this PR should not be linked to close the aforementioned issue.

From the presented view toolbar are the zoom icons meant to be clicked repeatedly to increase / decrease the zoom % factor? Or are they meant to be held down to drag over the surface? I'm asking because having these buttons would probably be duplicating the zoom slider that will be implemented by #1442 If anything perhaps that zoom slider widget could be moved to your toolbar instead after both PR's are merged.

Regarding the view toolbar itself, I understand you separated this one to contain the actions that affect the view itself such as zoom, mirror, etc. I just made a request in #1469 to separate the reset transforms. These individual buttons could also be added to this toolbar in that case.

I think it's great that the overlays will also have the grid toggle and adding the layout composition guides will make sense there. For the vector related buttons show outlines and show invisible I'd probably keep them in the overlays toolbar since just by the current division we could consider the overlays to affect how the user sees or filters the content without necessarily changing the view (unlike the usual transforms).

If I can think of anything else i'll comment again.

@Jose-Moreno
Copy link
Member

And note: some of the menu items don't have icons. We probably need to make them.

For this along the overall interface icons there was some progress discussed in #1356 and the PR is #1361 however it's true that there are plenty of missing icons for the menu actions

@chchwy
Copy link
Member Author

chchwy commented Sep 19, 2020

  1. Currently it's not customizable. It's always possible to implement the ability of toolbar customization in the future.
  2. The items on the toolbar are not decided yet. I will be happy to remove the zoom things if the status bar zoom slider code is merged.
  3. All the items on the toolbar are buttons at the moment, no drag, just click.
  4. I am going to add the rest of "DisplayOptions" to toolbars.
  5. Probably show outlines and show invisible could be in a separated "Vector" toolbar?

@Jose-Moreno Jose-Moreno linked an issue Oct 1, 2020 that may be closed by this pull request
@J5lx J5lx added Feature Request UX Related to the way users interact with the program labels Oct 22, 2020
@MrStevns MrStevns self-assigned this Nov 10, 2020
@MrStevns MrStevns removed their assignment Feb 25, 2021
Copy link
Member

@MrStevns MrStevns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me, I say we merge this one, it's been sitting there for far too long.

I found conflict markers in the latest commit, so I fixed that and will merge the PR now.
There are users who have been waiting for this for a long time, good job Matt 👍

More changes to the toolbar are welcome, but let's just take that in a separate PR.

@MrStevns MrStevns merged commit a2d5ac4 into pencil2d:master Jun 8, 2022
@MrStevns MrStevns added this to the v0.6.7 milestone Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Related to the way users interact with the program
Projects
Development

Successfully merging this pull request may close these issues.

Request a toolbar so can do Copy/Paste/Undo without keyboard
4 participants