-
Notifications
You must be signed in to change notification settings - Fork 286
Toolbars #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbars #1468
Conversation
And note: some of the menu items don't have icons. We probably need to make them. |
@chchwy Nice work. A quick note on #1455 that issue meant to be requesting an empty, fully customizable widget (I called it a toolbar but it could be a panel) that people can modify according to their preference and allow them to place any action available on Pencil2D menus or other panels as a quick access. In that sense this PR should not be linked to close the aforementioned issue. From the presented view toolbar are the zoom icons meant to be clicked repeatedly to increase / decrease the zoom % factor? Or are they meant to be held down to drag over the surface? I'm asking because having these buttons would probably be duplicating the zoom slider that will be implemented by #1442 If anything perhaps that zoom slider widget could be moved to your toolbar instead after both PR's are merged. Regarding the view toolbar itself, I understand you separated this one to contain the actions that affect the view itself such as zoom, mirror, etc. I just made a request in #1469 to separate the reset transforms. These individual buttons could also be added to this toolbar in that case. I think it's great that the overlays will also have the grid toggle and adding the layout composition guides will make sense there. For the vector related buttons show outlines and show invisible I'd probably keep them in the overlays toolbar since just by the current division we could consider the overlays to affect how the user sees or filters the content without necessarily changing the view (unlike the usual transforms). If I can think of anything else i'll comment again. |
|
- remove redundant menu separators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me, I say we merge this one, it's been sitting there for far too long.
I found conflict markers in the latest commit, so I fixed that and will merge the PR now.
There are users who have been waiting for this for a long time, good job Matt 👍
More changes to the toolbar are welcome, but let's just take that in a separate PR.
An initial PR of adding Toolbars. The toolbars are in a basic usable level that having only essential/frequently used items.
I want to bring it up early for your attention and discussion. More features/PRs will come later on.
Currently, there are 3 toolbar sections:
You can show/hide each of the toolbars under
Windows
menu.Implementing toolbars have two goals:
BTW, toolbars can be snap to any side of the main window, not only the top area.
