这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@scribblemaniac
Copy link
Member

@scribblemaniac scribblemaniac commented May 29, 2020

During testing of the latest version, I found many, many previously unknown issues, and there are still many known issues. This PR is to address as many of the "low-hanging fruit" before the next release. I will continue to add things to this for probably the next few days and I will remove the WIP when this is ready to merge. See commit messages for a list of changes.

Fixes #1234

The only way this code would be executed is when there is feather
and the alt key is held (command is handled in the block above).
However, all tools with feather use alt for the eyedropper, so
this is never used.
The cursor now stays and the inital place where pressed. Various
cosmetic changes have been applied to improve visibility and code
quality.
I believe the default focus policy for QSlider is StrongFocus,
but the focus when clicking behavior means that it will often
block shortcuts from working after performing certain actions.
@scribblemaniac scribblemaniac added this to the 0.6.5 milestone May 29, 2020
Having a multilayer onion skin setting would be good, but we don't
have that feature right now, so this action does nothing. Even if
we did have this feature, the menu isn't the best place for this
setting.
The recent file list was being wiped on startup because we are now
opening a project on startup (templates) which saves an empty
recent file list before the old one can be loaded. Additionally,
it was saving every time it clears the list, which is not a good
idea since that can be used internally before making other changes.
This was fixed and then reintroduced by pencil2d#1223. All points of a
selection need to be a whole number right now. Otherwise you have
borders drawn ambiguously between pixels, and obscure issues
when the values are rounded differently. For instance, flipping a
selection and then moving it could in some circumstances leave
behind a row/column of pixels.
Depending on the zoom level, the center overlay sometimes would
not show lines right in the center, or would only show half of the
lines because it is dashed. By drawing four lines from the center
instead of two through the center, it seems there will always be
lines at the center, even when zoomed out or in.
Also removed updateCurrentFrame in a few places because it will be
triggered by selectionChanged.
I've always hated this crap brown color on startup. Black is a
much more practical color and matches with the initial vector layer
color.
There were issues with not using the default preset when opening.
There were issues with the window title and save state not being
reset. There were probably other issues. Mostly from 7992c8f.
@J5lx
Copy link
Member

J5lx commented May 30, 2020

I can confirm this fixes #1017 on Arch Linux.

@J5lx J5lx linked an issue May 30, 2020 that may be closed by this pull request
In addition to be being a more logical location for this code, it
also allows for more customization of the quick sizing to each
tools specific needs. For example, the bucket tool uses it for
adjusting the fill expansion, but that only applies to the vector
layer so it should not be active when using the bitmap layer. The
pencil tool has a feather property, but it can't be changed, so
quick sizing should not be enabled for that.

Fixes pencil2d#1186
Having the command executed is particularly important so it can be
executed separately for testing purposes.
Specifically modified the select/move tools, cut, paste, and delete
selection actions.
I intially was fixing an issue where translucent colors would not
be picked correctly, and this was because it was not correctly
reversing the premultiply. I did some refactoring along with this
because there was lots of duplciated code between updateFrontColor
and pointerMoveEvent. When doing this, I noticed that there was
no check for getLast*ImageAtFrame returning null, which means that
Pencil2D will instantly crash with the eyedropper tool whenever
they current frame is before the first keyframe. All these issues
have been fixed.
@chchwy
Copy link
Member

chchwy commented Jun 3, 2020

Will be reviewing this PR and merge it soon

@chchwy
Copy link
Member

chchwy commented Jun 5, 2020

@scribblemaniac not sure if you saw it, I sent a PR to this branch fixing mac compiler failure.
scribblemaniac#6

@chchwy chchwy merged commit 2a27d50 into pencil2d:master Jun 8, 2020
@scribblemaniac scribblemaniac changed the title [WIP] Pre release fixes Pre release fixes Jun 14, 2020
@scribblemaniac scribblemaniac changed the title Pre release fixes Pre release fixes 1 Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ISSUE] The Quick Sizing Tool does not work properly wrong cursor icon when using a tablet

3 participants