Add OpenSSL .dlls to enable https requests #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This also fixes the issues reported under Windows 7 🎉 |
MrStevns
approved these changes
May 3, 2019
Member
MrStevns
left a comment
There was a problem hiding this comment.
LGTM. 👍
My only comment is regarding local compilation. We should consider having the binaries somewhere or it should be mentioned on the wiki that it is required on Windows.
Member
Author
|
@candyface I'll update the compilation guide on the wiki and docs/build_win.md. Although now that I look at them, we are also missing the instructions installing the ffmpeg plugin from all build instructions. |
Member
Author
|
I will merge this now and make a new issue to update the documentation later so that we can get this update out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested the 64-bit binaries from https://indy.fulgan.com/SSL/ with v0.6.3 of Pencil2D and this fixes the Updater error on Windows 10.
Fixes #1195